fix(deps): move shared-core to 0.4.1, which has the KikCode figure API - #723
Merged
Conversation
0.4.0 was published from `code/cash`, and the publish workflow re-copies the Swift package from the checkout after deleting it — so it dropped the CGPath figure wrappers, which had only ever existed on the branch 0.3.1 came from. `main` has not built since the bump: `type 'KikCode' has no member 'figure'`. 0.4.1 restores them (code-android-app#1401). The floor moves from 0.4.0 to 0.4.1 rather than leaving `.upToNextMinor` to find it, so a fresh resolve cannot land back on the one published version that is missing the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas not built since the 0.4.0 bump:The CGPath figure wrappers only ever existed on the branch 0.3.1 was published from, and that
branch never merged. 0.4.0 was published from
code/cash, where the publish workflow stages theSwift package by deleting
SourcesandTestsand re-copying from the checkout — so cutting itremoved the API rather than carrying it forward. Details in
code-android-app#1401, which restores
the sources; 0.4.1 is cut from
code/cashwith them in.Pinning back to 0.3.1 was never available —
FlipcashCoreusesSharedCoreKit.Base58,SharedEd25519and the Hashes wrappers, none of which exist there.The floor moves to 0.4.1 rather than letting
.upToNextMinor(from: "0.4.0")pick it up, so a freshresolve cannot land back on the one published version missing the API.