Skip to content

test(chat): cover the selection bar's re-narrowing of a stale bubble #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Sep 4, 2026
Merged

test(chat): cover the selection bar's re-narrowing of a stale bubble #1406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions ...enger/src/test/kotlin/com/flipcash/app/messenger/internal/ChatMessageActionReducerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ package com.flipcash.app.messenger.internal
import androidx.compose.foundation.text.input.TextFieldState
import com.flipcash.services.models.chat.MessageContent
import com.flipcash.shared.chat.MessageCapability
import com.flipcash.shared.chat.MessagePolicy
import com.flipcash.shared.chat.models.ChatListItem
import kotlin.test.Test
import kotlin.test.assertEquals
import kotlin.test.assertFalse
import kotlin.test.assertNotNull
import kotlin.test.assertNull
import kotlin.test.assertTrue
import kotlin.time.Duration.Companion.minutes
import kotlin.time.Instant

/**
Expand Down Expand Up @@ -58,6 +60,36 @@ class ChatMessageActionReducerTest {
assertEquals(target.capabilities, state.selectionCapabilities)
}

@Test
fun `selecting a bubble past its edit window drops Edit`() {
// The transcript resolved this bubble when it was mapped, which may have been well inside a
// window that has since closed. Offering Edit anyway costs a round-trip the server answers
// CANNOT_EDIT. sentAt is decades old, so any finite window here has closed.
val state = reduce(
ChatViewModel.State(messagePolicy = MessagePolicy(editWindow = 5.minutes)),
ChatViewModel.Event.ToggleMessageSelection(bubble(1)),
)

assertEquals(
setOf(MessageCapability.Copy, MessageCapability.Delete),
state.selectionCapabilities,
)
}

@Test
fun `selecting a bubble past its delete window drops Delete`() {
// Separate from the case above so a window wired to the wrong capability cannot pass both.
val state = reduce(
ChatViewModel.State(messagePolicy = MessagePolicy(deleteWindow = 5.minutes)),
ChatViewModel.Event.ToggleMessageSelection(bubble(1)),
)

assertEquals(
setOf(MessageCapability.Copy, MessageCapability.Edit),
state.selectionCapabilities,
)
}

@Test
fun `long-pressing the selected bubble again clears the bar`() {
val target = bubble(1)
Expand Down
Loading