fix(userflags): give the message window overrides their test cases - #1405
Merged
Conversation
Making the edit and delete windows overridable (#1403) added messageEditWindow and messageDeleteWindow to Overrides without adding matching entries to OverrideCases. The guard test that exists to catch exactly that has failed on code/cash since the merge, taking the userflags module's test task down on every PR. Adding the two cases restores the guard and puts the fields under the resolve() checks the rest of the list gets. Both override values differ from the server baseline, per the note above the list, so a field reading the wrong override cannot pass by coincidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResolvedUserFlagsTest > every Overrides field has a casehas failed oncode/cashsince #1403 merged, taking:apps:flipcash:shared:userflags:testDebugUnitTestdown on every PR.That PR made the message edit and delete windows overridable, adding
messageEditWindowandmessageDeleteWindowtoOverrideswithout matching entries inOverrideCases. The guard test exists to catch precisely this — its doc says a new field onOverrideshas to gain a case here — so it was doing its job.Adding the two cases restores the guard and brings both fields under the
resolve()checks the rest of the list already gets: that an override lands on its own field, leaves the others alone, and is not reported forOverrides.None. Both override values differ from the server baseline (45s against 15s, 120s against 60s), per the note above the list, so a field reading the wrong override cannot pass by coincidence.