feat(tipping): give the Chats tab the standard centred title - #1382
Merged
Conversation
The large title was the only one of its kind in the app, and it left the list running to a hard cut at both edges. Drop `screenTitleLarge` so the bar falls back to `screenTitle`, and centre it: with no leading control the slot reserves no width, so a Start-aligned title sits flush at the inset and reads off-centre against the Add button. Fade the list with `verticalScrollStateGradient`, applied after the scaffold padding so the gradient lands on the viewport flush under the bar rather than on the bar's own space. It only draws at an edge that can still be scrolled toward, so the empty state — which fills the viewport and cannot scroll — is unfaded. `screenTitleLarge` now has no callers; left in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Chats tab was the only screen in the app with a large flush-start title, and its list ran to a hard cut at both edges.
titleTextStyle = screenTitleLargeso the bar falls back toscreenTitle, and passtitleAlignment = Alignment.CenterHorizontally. The alignment is not redundant: with no leading control the slot reserves no width, so a Start-aligned title sits flush at the inset and reads off-centre against the Add button.verticalScrollStateGradient, applied after the scaffold padding so the gradient lands on the list viewport flush under the app bar rather than on the bar's own space. The helper only draws at an edge that can still be scrolled toward, so the empty state, which fills the viewport and cannot scroll, stays unfaded.CodeTheme.typography.screenTitleLargenow has no callers. Left in place rather than removed as part of this change.