Skip to content

fix(profile): confirm the reversible profile changes in the grey banner #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Aug 31, 2026
Merged

fix(profile): confirm the reversible profile changes in the grey banner #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions apps/flipcash/core/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,18 +967,20 @@
<!-- Confirmation before a profile edit is committed. Only shown on a change: a first display
name, username, picture, or minimum tip overwrites nothing, so there is nothing to warn
about. Username carries the extra sentence because the old handle is released on change
and someone else can claim it. -->
and someone else can claim it — the only one of the four the user may not be able to undo,
so the only one shown in the red banner. The rest state what the change does and confirm in
the grey one. -->
<string name="prompt_title_changeDisplayName">Change Display Name?</string>
<string name="prompt_description_changeDisplayName">Are you sure you want to permanently change your display name?</string>
<string name="prompt_description_changeDisplayName">This will change your display name</string>
<string name="action_changeDisplayName">Change Display Name</string>
<string name="prompt_title_changeUsername">Change Username?</string>
<string name="prompt_description_changeUsername">Are you sure you want to permanently change your username? You might not be able to get your old username back</string>
<string name="action_changeUsername">Change Username</string>
<string name="prompt_title_changeProfilePicture">Change Profile Picture?</string>
<string name="prompt_description_changeProfilePicture">Are you sure you want to permanently change your profile picture?</string>
<string name="prompt_description_changeProfilePicture">This will change your profile picture</string>
<string name="action_changeProfilePicture">Change Profile Picture</string>
<string name="prompt_title_changeMinimumTip">Change Minimum Tip?</string>
<string name="prompt_description_changeMinimumTip">Are you sure you want to permanently change your minimum tip?</string>
<string name="prompt_description_changeMinimumTip">This will change your minimum tip</string>
<string name="action_changeMinimumTip">Change Minimum Tip</string>

<!-- A tapped `flipcash.com/{username}` link that resolves to nothing. -->
Expand Down
2 changes: 1 addition & 1 deletion .../src/main/kotlin/com/flipcash/app/userprofile/internal/mintip/MinimumTipEntryViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ internal class MinimumTipEntryViewModel @Inject constructor(
dispatchEvent(Event.CommitRequested(amount))
return@onEach
}
BottomBarManager.showAlert(
BottomBarManager.showMessage(
title = resources.getString(R.string.prompt_title_changeMinimumTip),
message = resources.getString(R.string.prompt_description_changeMinimumTip),
actions = listOf(
Expand Down
2 changes: 1 addition & 1 deletion ...-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/name/NameEntryViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class NameEntryViewModel @Inject constructor(
dispatchEvent(Event.CheckName(event.source))
return@onEach
}
BottomBarManager.showAlert(
BottomBarManager.showMessage(
title = resources.getString(R.string.prompt_title_changeDisplayName),
message = resources.getString(R.string.prompt_description_changeDisplayName),
actions = listOf(
Expand Down
2 changes: 1 addition & 1 deletion ...le/src/main/kotlin/com/flipcash/app/userprofile/internal/photo/PhotoSelectionViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class PhotoSelectionViewModel @Inject constructor(
dispatchEvent(Event.CheckImage)
return@onEach
}
BottomBarManager.showAlert(
BottomBarManager.showMessage(
title = resources.getString(R.string.prompt_title_changeProfilePicture),
message = resources.getString(R.string.prompt_description_changeProfilePicture),
actions = listOf(
Expand Down
Loading