fix(chat): stop naming the reserve in the cash preview - #1376
Merged
Conversation
A cash message preview appended the token name whenever the message carried one, so a Dollars transfer read "You sent $1.00 of Dollars". USDF is branded "Dollars", and the formatted amount already carries the dollar sign, so the suffix repeats the unit it just printed. The reserve mint now resolves to an empty name, which drops the preview to the bare amount. Every other token still gets named, since "$1.00 of Waylon" is the only thing that says which currency moved. Same rule the swap processing screen applies through `isConvertingToDollars`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cash message preview appended the token name whenever the message carried one, so a Dollars transfer read "You sent $1.00 of Dollars". USDF is branded "Dollars" and the formatted amount already carries the dollar sign, so the suffix repeats the unit it just printed.
formatPreviewinChatSummaryMappingtookcontent.tokenNameunconditionally, falling back to the mint lookup, and wrapped any non-blank result inlabel_chat_preview_cash_suffix("%1$s of %2$s"). The reserve mint now resolves to an empty name, which drops the label to the bare formatted amount. Every other token still gets named, since "$1.00 of Waylon" is the only thing that says which currency moved.This is the same rule the swap processing screen already applies through
isConvertingToDollars.MessageBubble'sCashBubblestill renders the icon-and-name header for the reserve. That reads as a token identity chip rather than a sentence, so it is left alone here.