Skip to content

perf(r8): drop the protobuf and gRPC server keep rules #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 3 commits into from
Aug 31, 2026
Merged

perf(r8): drop the protobuf and gRPC server keep rules #1370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bbdf84
perf(r8): drop the protobuf and gRPC server keep rules
bmc08gt Aug 30, 2026
10dd8ff
Merge remote-tracking branch 'origin/code/cash' into perf/narrow-prot…
bmc08gt Aug 31, 2026
6d99fed
build(deps): take the contract packages at 0.3.0 for their keep rules
bmc08gt Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions apps/flipcash/app/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@
-keepnames class com.flipcash.app.core.AppRoute
-keepnames class com.flipcash.app.core.AppRoute$**

# Protobuf — keep all generated message classes and their builders.
# Using type-hierarchy rules so new packages / updated gRPC stubs are
# caught automatically instead of listing every gen package.
-keep class * extends com.google.protobuf.GeneratedMessageLite { *; }
-keep class * extends com.google.protobuf.GeneratedMessageLite$Builder { *; }
# Protobuf keep rules ship with the contract packages themselves, from 0.3.0 on:
# com.flipcash:{ocp,flipcash2}-client-protocol carry them in META-INF/proguard/, which
# R8 reads straight out of the jar. Downgrading either pin below 0.3.0 silently removes
# the app's only protobuf keep rule.

# gRPC — keep generated service stubs (abstract + concrete)
# gRPC — keep the generated client stubs
-keep class * extends io.grpc.stub.AbstractStub { *; }
-keep class * implements io.grpc.BindableService { *; }

# Keep our scan classes that interact with native. The scanner's JNI constructs
# these from C++ by name (FindClass("com/kik/scan/UsernameKikCode"), GetMethodID
Expand Down
6 changes: 4 additions & 2 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,10 @@ protovalidate-kt = "0.1.1"
# Generated client SDKs for the two backend contracts. Separate versions on purpose: the
# protos are independent (flipcash2 does not import ocp), so the packages move on their own
# cadence and there is nothing to keep aligned.
ocp-client-protocol = "0.2.0"
flipcash2-client-protocol = "0.2.0"
# 0.3.0 is the first release of either package to ship R8 keep rules for its generated
# messages, which is what lets proguard-rules.pro drop its own.
ocp-client-protocol = "0.3.0"
flipcash2-client-protocol = "0.3.0"

# The Android port is the ONLY libphonenumber this app depends on, deliberately. Google's
# `com.googlecode` artifact used to sit alongside it; the two ship separate copies of the metadata,
Expand Down
Loading