fix(tokens): lead the Get receipt with You Pay - #1312
Merged
Conversation
Swaps the Get receipt's two anchors so the amount charged sits above the fee breakdown and the amount received closes the card. The breakdown lines total to the top figure now, so they read as its itemisation. Gated on isGet: the v1 Buy receipt, and v2's Add Money, still lead with You Receive.
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the two anchor rows on the Get receipt so the card leads with what the purchase costs.
Before:
You Get→ Amount to convert / Conversion fee →You PayAfter:
You Pay→ Amount to convert / Conversion fee →You GetBeyond the ordering itself, this puts the breakdown lines directly under the figure they add up to —
Amount to convert + Conversion fee = You Pay— so they read as its itemisation instead of as a forward reference to a total further down the card.Notes for review
isGet, following the precedent already in this file forlineSpacing. The v1 Buy receipt and v2's Add Money both still render throughTokenBuyReceiptScreenand both keep leading withYou Receive— neither moves here.received/paidlocals and the order is picked at the call site. No change to either anchor's token, amount, or fee math:You Payis still purchase + fee,You Getis still the purchase amount.Anchorrenders top and bottom identically — no directional styling or arrow — so this is a pure ordering change with no layout work behind it.SwapReceiptScreendoc comment described Get as "You Get / … / You Pay"; corrected to match.BuyConfirmationScreen. Land them together so the Get receipt doesn't read differently on each platform.