docs: correct debug applicationId and google-services.json path - #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two build-setup claims in the docs no longer match the build.
Debug
applicationId— the docs say debug installs ascom.flipcash.app.android.dev. There is noapplicationIdSuffixanywhere in the Gradle files;apps/flipcash/app/build.gradle.ktssetsapplicationId = appNamespacewith no per-buildType override, so debug and release sharecom.flipcash.app.androidand installing one replaces the other. Found this the hard way —adb shell monkey -p com.flipcash.app.android.devreturns "No activities found to run".google-services.jsonlocation — the docs point only atapps/flipcash/app/src/. The checked-out copy actually lives at the module root,apps/flipcash/app/, and builds fine from there (processDebugGoogleServices --rerun-taskspasses). CI writes it tosrc/(.github/workflows/ci.yml:65) and also passes, so the Google Services plugin accepts either — the docs now say so rather than naming one path.Same two claims were repeated across
CLAUDE.md,docs/architecture/10-build-and-run.md, anddocs/architecture/08-cross-cutting-concerns.md.