feat(wallet): add Withdraw and Create-a-Currency action tiles - #1254
Merged
Conversation
Ports code-payments/code-ios-app#598. The v2 Wallet's action row becomes a 2x2 grid: Add Money | Withdraw Money Discover Currencies | Create a Currency - Add/Withdraw use the app's canonical matched glyph pair (ic_menu_deposit / ic_menu_withdraw, as on the Settings money tiles) instead of an ad-hoc Material icon; Create a Currency gets a new ic_coins_add vendored from the design. - Withdraw pushes AppRoute.Transfers.Withdrawal onto the wallet's own stack, so it pops back to the Wallet (iOS needed .withdrawCurrency for the same reason). - Discover drops its floating currency-creator promo now that creation lives on the Wallet; the legacy inline promo is untouched, so this is v2-only. Tile corner radius already matches the design token (shapes.extraSmall, 6dp) on both the wallet tiles and the currency-info action tiles — no change needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports code-payments/code-ios-app#598.
The v2 Wallet's action row becomes a 2x2 grid:
Changes
ic_menu_deposit/ic_menu_withdraw, as on the Settings money tiles) instead of an ad-hoc Material icon. Create a Currency gets a newic_coins_addvendored from the design.AppRoute.Transfers.Withdrawalonto the wallet's own stack so it pops back to the Wallet (iOS needed.withdrawCurrencyfor the same reason).Tile corner radius already matched the design token (
shapes.extraSmall, 6dp) on both the wallet tiles and the currency-info action tiles — no change needed there.Flag gating
v2-only:
WalletScreenContentis the NewUi wallet, and the legacy inline currency-creator promo on Discover is untouched.