feat(tabs): badge the Chat tab with unread chats - #1253
Merged
Conversation
Ports code-payments/code-ios-app#597. The v2 tab bar now badges the Chat tab with the unread tip-DM conversation count, mirroring the v1 scanner bar's Tips badge — same reactive source (SessionState.tipsUnreadCount), so it appears, updates and clears as conversations are read. - NavigationBarState gains badgeCount(button): Tips (v1) and Chats (v2) are the same tip-DM inbox under the two UIs. - NavigationBarV2 overlays the shared Badge in the brand indicator blue on the glyph's top-right corner, matching the iOS placement. The tab item is no longer clipped so the badge can overhang; safe because its click indication is null, so there is no ripple needing bounds. - AppNavigationBar feeds the count from the session controller. Inherently v2-only: NavigationBarV2 only renders under FeatureFlag.NewUi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports code-payments/code-ios-app#597.
The v2 tab bar now badges the Chat tab with the unread tip-DM conversation count, mirroring the v1 scanner bar's Tips badge. Both read the same reactive source (
SessionState.tipsUnreadCount), so the badge appears, updates and clears as conversations are read.Changes
NavigationBarStategainsbadgeCount(button)— Tips (v1) and Chats (v2) are the same tip-DM inbox under the two UIs.NavigationBarV2overlays the sharedBadgein the brand indicator blue on the glyph's top-right corner, matching the iOS placement. The tab item is no longer clipped so the badge can overhang; that is safe because its click indication isnull, so there are no ripple bounds to preserve.AppNavigationBarfeeds the count from the session controller.Flag gating
Inherently v2-only —
NavigationBarV2only renders underFeatureFlag.NewUi. The v1 scanner bar is untouched.