refactor(bills): move bill decorators + modals into :shared:bills - #1218
Merged
Conversation
Phase A of hosting bills at the app root: relocate the below-bill decorators (ScannableDecorator/PayableDecorator/TipCardDecorator) and their modals (BillManagementOptions, ReceivedFundsConfirmation, TipUserModal) out of :features:scanner into :shared:bills, so the bill overlay can later be hosted outside the scanner. Pure move — no behavior change. - ScannableDecorator + ScannableDecoratorContext become public (the scanner now consumes them cross-module); the concrete decorators/modals stay internal to :shared:bills. - :shared:bills gains a :shared:session dependency (for LocalSessionController). The 7 string resources resolve transitively (:core + :ui:resources), so none were moved. - ScannableContainer repointed to the new com.flipcash.app.bills.decor package.
github-actions
Bot
added
area: payments
bmc08gt
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase A of moving bill rendering to the app root: relocate the below-bill decorators and their modals out of
:features:scannerinto:shared:bills. Pure move — no behavior change — so the eventual root-level bill overlay can host them.Moved (6 files):
decor/→ScannableDecorator,PayableDecorator,TipCardDecoratorBillManagementOptions,modals/ReceivedFundsConfirmation,modals/TipUserModalDetails:
ScannableDecorator(sealed interface) +ScannableDecoratorContextbecome public — the scanner still consumes them, now cross-module. Concrete decorators/modals stayinternalto:shared:bills.:shared:billsgains a:shared:sessiondep (LocalSessionController). No dependency cycle (:shared:sessiondoesn't depend on:shared:bills).:core+:ui:resources); none moved.Rimport repointed tocom.flipcash.shared.bills.R.ScannableContainerrepointed to the new package.Follow-up (Phase B): a root-level
BillOverlayinApp.kt, scanner slim-down, frosting removal.Test Plan
:shared:bills,:features:scanner,:appcompile (verified: BUILD SUCCESSFUL)