feat(nav): slide in-tab pushes, keep crossfade on tab switches - #1217
Merged
Conversation
The v2 tab nav host crossfaded every transition. Now a forward move that lands on a tab home (Scanner/Wallet, via asNavBarTab) crossfades — a tab switch — while any other forward move slides in (a push into a detail screen) and pops slide back out. Overlays/sheets keep their no-transition. Also switch the wallet's OpenScreen navigation from openAsSheet to push so detail screens (e.g. Token Info) get the slide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Differentiate navigation transitions in the v2 tab host: tab switches crossfade, in-tab pushes slide.
NewAppContent) crossfaded every transition.asNavBarTab) crossfades — a tab switch (replaceAll) — while any other forward move slides in (a push into a detail screen) and pops slide back out. Overlays/sheets keep their no-transition path.codeNavigator.currentRouteKey(theScene.keyis not theAppRouteat runtime).OpenScreennavigation fromopenAsSheettopush, so detail screens (e.g. Token Info) get the slide.Test Plan