refactor: consolidate activity feed into :shared:transaction-history - #1214
Closed
bmc08gt wants to merge 8 commits into
Closed
refactor: consolidate activity feed into :shared:transaction-history#1214bmc08gt wants to merge 8 commits into
bmc08gt wants to merge 8 commits into
Conversation
…dation Marks ActivityFeedCoordinator/ActivityFeedUpdater @deprecated (WARNING, non-breaking — no allWarningsAsErrors) pointing at the go-forward home :shared:transaction-history, and adds a phased consolidation plan. The activity-feed module is the data engine v2's unified history runs on, so this is a consolidation (move it next to the presentation it feeds), not a removal of behavior. The plan uses a forwarding-typealias shim so the 5 dependents migrate one at a time and the module is deleted last, gated on the v2 (FeatureFlag.NewUi) launch. Module move is NOT in this change — plan review first.
…rom :shared:activityfeed Scaffolds :apps:flipcash:shared:transaction-history and relocates the two classes into it (package com.flipcash.shared.transactionhistory). The old :shared:activityfeed keeps @deprecated forwarding typealiases and now depends on the new module via api() so callers still importing com.flipcash.app.activityfeed resolve transitively. Zero dependent edits; app assembles and the Hilt graph is intact. Plan Task 2.
…action-history Plan Task 3.
…transaction-history Plan Task 4.
…ansaction-history Plan Task 5.
…ction-history Plan Task 6.
…tory Plan Task 7. Covers ActivityFeedUpdater (a plain @Inject dependency in RealSessionController) as well as ActivityFeedCoordinator.
github-actions
Bot
added
type: refactor
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase out the deprecated
:shared:activityfeedmodule and consolidate the activity-feed domain into:shared:transaction-historyahead of the v2 wallet work. Pure move/refactor — no behavior change.:shared:activityfeed(module + phase-out plan).ActivityFeedCoordinator/ActivityFeedUpdaterinto:shared:transaction-history.Base for the stacked feature PR (wallet recent activity).
Test Plan
./gradlew :apps:flipcash:app:assembleDebugcompiles