fix(chat): tip amount-entry — enforce minimum on send + simplify slide label - #1188
Merged
Conversation
…ne screen - Always use action_swipeToSend for the amount-entry slide action; the tip minimum is still surfaced via belowMinHint, so tip DMs keep their minimum enforcement without a separate slide label. - Remove the unused standalone ChatAmountEntryScreen composable (and its now-dead imports); the flow-scoped FlowAmountEntryScreen / ChatAmountEntryContent path is the only entry point. - Minor whitespace fix on State.separatorConfig.
bmc08gt
changed the title
Guard the send path: when the chat is a tip DM with a minimum and the entered amount is below it, surface a "<min> Minimum" alert and abort the send instead of proceeding. Reword the tip-minimum error strings to match. Pairs with the slide label simplification — the minimum is now enforced at send time rather than implied by a dedicated "Swipe to Tip" label.
bmc08gt
force-pushed
the
chore/chat-amount-entry-cleanup
branch
from
August 6, 2026 18:03
394ac1d to
26c0dd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tightens up the messenger tip amount-entry flow:
Enforce tip minimum on send
Guard the send path so a tip DM below its minimum can't go through: when the entered amount is under
minAmountFlow, show a " Minimum" alert and abort the send. Previously the minimum was only hinted (belowMinHint) and not enforced at send time. Reworded the two tip-minimum error strings to match (error_title_tipMinimum,error_description_tipMinimum).Simplify slide label
Always use
action_swipeToSendfor the amount-entry slide action instead of switching toaction_swipeToTipfor tip DMs. With enforcement now happening at send time, the dedicated tip label is redundant. Tip minimum behavior is unchanged aside from the label text.Cleanup
ChatAmountEntryScreen(identifier)composable and its now-dead imports (no remaining call sites; the flow-scopedFlowAmountEntryScreen→ChatAmountEntryContentpath is the only entry point).State.separatorConfig.Testing
:apps:flipcash:features:messenger:compileDebugKotlinpasses.