Skip to content

fix(chat): allow swipe-to-dismiss on the conversation sheet #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Aug 6, 2026
Merged

fix(chat): allow swipe-to-dismiss on the conversation sheet #1187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...ger/src/main/kotlin/com/flipcash/app/messenger/internal/screens/components/MessageList.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ import com.flipcash.shared.chat.models.SeparatorConfig
import com.flipcash.shared.chat.ui.bubblePositionOf
import com.getcode.theme.CodeTheme
import com.getcode.ui.utils.rememberKeyboardController
import com.getcode.ui.utils.sheetResignmentBehavior
import com.getcode.util.vibration.LocalVibrator
import kotlinx.coroutines.flow.collectLatest
import kotlinx.coroutines.flow.distinctUntilChanged
Expand Down Expand Up @@ -122,8 +121,14 @@ internal fun MessageList(
}

LazyColumn(
// NB: no sheetResignmentBehavior here. That guard is built for top-anchored lists,
// where index0/offset0 is the scroll edge that abuts the sheet's downward dismiss drag.
// This list is reverseLayout=true, so index0/offset0 is the *resting* position (newest),
// and a downward drag there scrolls into history rather than overscrolling. Applying the
// guard would flip the sheet's allowDismiss to false at rest and never cleanly re-enable
// it, so the sheet snaps back instead of dismissing. Dismiss here comes from the
// header/handle drag, scrim tap, and back — all gated by that same allowDismiss flag.
modifier = modifier
.sheetResignmentBehavior(listState)
.pointerInput(Unit) {
detectTapGestures { keyboard.hide() }
},
Expand Down
Loading