feat(flipcash): tip DM origin + flipcash proto update - #1186
Merged
Conversation
Re-vendor flipcash protos at upstream HEAD: - messaging/v1: rename CashContent enum Action->Verb, field action->verb - intent/v1: add TipDmPayment.Location enum (TIPCARD/CHAT) + location field Update the network extension mappers for the CashContent verb rename.
Report where a tip DM payment was initiated to the backend via the new TipDmPayment.location proto field. Add a TipOrigin domain enum, thread it through TipPaymentDelegate.send(), and set TIPCARD for the out-of-chat tipping flow and CHAT for the in-chat messenger send.
github-actions
Bot
added
type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-vendors the flipcash protos at upstream HEAD and wires up the new tip-DM
locationsignal.Proto changes
CashContentenumAction→Verb, fieldaction→verb(field number 4 and enum valuesSENT/TIPPEDpreserved).TipDmPaymentgains aLocationenum (TIPCARD=0/CHAT=1) +locationfield.Code changes
LocalToProtobuf/ProtobufToLocal) for theCashContentverb rename.TipOrigindomain enum and thread it throughTipPaymentDelegate.send()so the backend learns where a tip DM was initiated:TippingCoordinator) →TIPCARDChatViewModel) →CHATThe
MessageContent.Cash.Actiondomain enum and its persistence/chat-ui consumers are untouched (they never referenced proto types).Verification
Builds pass for
:definitions:flipcash:models,:services:flipcash,:apps:flipcash:shared:payments,:apps:flipcash:shared:tipping, and:apps:flipcash:features:messenger.