Repository navigation
fix: stamp the real signing date next to the signature - #40
Merged
Merged
Conversation
The date beside the signature was printed by create_contract_pdf, i.e. when the contract was generated. Signing usually happens days later, so a contract signed on the 21st still showed the 16th — and the date never changed no matter when it was signed. Generation now leaves that field blank and the date is stamped during signing, at the position the contract layout owns (SIGNATURE_DATE_POS). embed_signature gained an optional text_stamps argument so it lands in the same save as the signature. The header 'Date:' still records when the contract was drawn up. Adds a regression test covering both halves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The date beside the signature was printed at contract generation, so a contract signed days later still showed the generation date and never updated. Generation now leaves it blank and the signing date is stamped during signing, via a new optional text_stamps argument on embed_signature (same save as the signature). Regression test added.