Repository navigation
fix: stop deleting the signed contract when it is downloaded - #38
Merged
Merged
Conversation
/pdf/download scheduled remove_task() as a background task, wiping the whole task directory the first time the file was fetched. The dashboard opens that link automatically right after signing, so every signed internship agreement was destroyed on first download: the contract preview 404'd and emailing it failed with 'Signed contract file is missing'. This delete-after-download came from the service's one-shot PDF-signing origins; here the agreement is a lasting record that is previewed, re-downloaded and emailed. The cleanup on *failed upload* is unaffected. Adds a regression test that downloads twice (verified: it fails if the deletion is reintroduced).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/pdf/download scheduled remove_task() as a background task, wiping the task directory the first time the file was fetched. The dashboard opens that link automatically right after signing, so every signed internship agreement was destroyed on first download - contract preview 404d and emailing failed with Signed contract file is missing. This came from the one-shot PDF-signing origins of the service; here the agreement is a lasting record that is previewed, re-downloaded and emailed. Cleanup on failed upload is unaffected. Adds a regression test (verified it fails if the deletion is reintroduced).