Repository navigation
fix: surface the real reason a contract email fails - #37
Merged
Merged
Conversation
The API sits behind a CDN that rewrites upstream 5xx into its own plain 'error code: 502' page, so the coordinator only ever saw 'Failed to fetch' and the actual cause never reached the browser or the logs. - log the failure server-side, including the exception type (connect/DNS errors often carry an empty message) - return 424 Failed Dependency instead of 502, and 409 instead of 503, so the JSON detail passes through the CDN untouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API sits behind a CDN that rewrites upstream 5xx into its own plain error page, so the coordinator only saw Failed to fetch and the real cause never reached the browser or the logs. Now: log the failure server-side including the exception type, and return 424 instead of 502 (409 instead of 503) so the JSON detail passes through the CDN.