Fix/exposed value view delete record#1302
Merged
Merged
Conversation
Adds a spec mirroring how Sandbox wires ExposedValueView (a storage object keyed by a slot key, exposed to children under a record name). Includes a case for deleting the entire exposed record, which currently fails: deleteItem guards on container.hasOwnProperty(recordName) instead of the slot key, so the delete is a silent no-op and the slot survives.
deleteItem guarded on container.hasOwnProperty(path) where path is the record name (e.g. "$page"), but the container is keyed by the slot key (this.key). The check never matched, so deleting the whole exposed record was a silent no-op — a sandboxed page's state survived in storage and was re-exposed on the next visit. Guard on this.key, matching setItem and the delete below it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.