Repository navigation
Minor version bump not working after version 2.8.2 in some cases #114
Description
Activity
Today I found out the same was happening to me. In my case, the major and minor-identifiers where "INC_MAJOR:" and "INC_MINOR:". Through trial and error I eventually learned that I could only get correct behavior when the identifiers were set to use lowercase strings (ex "inc_minor:"). I think either the commit message or the identifier values are getting lowercased prior to attempting to match. not sure which.
Reacted by Max O'CullI just determined that it was forcing the commit title to lowercase. Thus, when the minor-identifier value was all caps, it never matched
minor-identifier commit message outcome INC_MINOR: INC_MINOR: no match inc_minor: inc_minor: match INC_MINOR: inc_minor: no match inc_minor: INC_MINOR: match Reacted by Max O'CullIt looks like this is the offending line
git-version/src/git-version.cr
Line 172 in 637c585
Reacted by Max O'Cull
I recently tried increasing my minor version by making a commit (git hub PR merge) have a value matching my "minor-identifier" value, which is "minor:". We are currently running the latest version of the action, 2.8.6.
This resulted in the minor version not increasing as expected and instead the patch version increased.
I've been trying to get to the source of the problem and haven't been able to. I went back to older versions of the action and the minor version properly increases at version 2.8.2. Unfortunately I can't really test any versions between 2.8.2 because they are all broken with the issue that was fixed in version 2.8.6 (the extra space in the action file).
I've tried setting the "tool-version" value to various versions and that doesn't seem to change behavior, so I'm not 100% what that actually does.
I also tried making a normal commit that matches my "minor-identifier" and in that case version 2.8.6 did increase the minor version.
I'm lost as to the cause of the failure to increase the minor version at this point and would appreciate any help in tracking down the root cause.