Repository navigation
Conversation
Bumped .tool_version and the Dockerfile OPENGREP_VERSION ARG together in lock-step.
github.com/opengrep/opengrep-rules is archived and its release branch no longer exists, so the commit pin in internal/docgen/parsing.go is now frozen at that repo's last main commit (which the existing pin already matches). Updated the README so the playbook and Generate Docs steps stop pointing agents at a branch that no longer exists.
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
No merge-blocking issues were identified. Codacy reports the changes are up to standards, with no new issues or complexity findings. Required validation evidence is not present in the supplied changes, so the release alignment and documentation updates should be verified by running the listed tests.
Test suggestions
- Verify
.tool_versionand DockerfileOPENGREP_VERSIONresolve to the same Opengrep release. - Run the documentation generator successfully against the frozen rules pin.
- Build the Docker image and verify the bundled binary reports Opengrep 1.30.0.
- Run the Go unit test suite excluding
/docs/. - Run the
codacy-plugins-testpatternandmultiplesuites against the built image.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify `.tool_version` and Dockerfile `OPENGREP_VERSION` resolve to the same Opengrep release.
2. Run the documentation generator successfully against the frozen rules pin.
3. Build the Docker image and verify the bundled binary reports Opengrep 1.30.0.
4. Run the Go unit test suite excluding `/docs/`.
5. Run the `codacy-plugins-test` `pattern` and `multiple` suites against the built image.
Low confidence findings
- The PR's required validation commands are not evidenced by the supplied changes; please run and record the documented generator, Go, Docker, and plugin test suites.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tool_versionand the DockerfileOPENGREP_VERSIONARG to v1.30.0 (in lock-step).opengrep/opengrep-rulesis archived and itsreleasebranch no longer exists — the existing commit pin ininternal/docgen/parsing.goalready matches that repo's frozenmainHEAD, so no code change was needed there, just doc updates so future agents don't chase a dead branch.Test plan
go run ./cmd/docgencompletes without errorsgo test $(go list ./... | grep -v /docs/)passesdocker build --build-arg TOOL_VERSION=$(cat .tool_version) -t codacy-opengrep:latest .succeeds, binary reports1.30.0codacy-plugins-testpatternsuite passes locallycodacy-plugins-testmultiplesuite passes locally