Skip to content

Handle symlinks from breaking the tool #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DMarinhoCodacy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle symlinks from breaking the tool #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a015fac
Handle symlinks from breaking the tool
DMarinhoCodacy Sep 18, 2026
ee08cc1
Improve Output parser
DMarinhoCodacy Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 36 additions & 12 deletions internal/tool/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,31 @@ func executeCommandForFiles(configurationFile *os.File, toolExecution codacy.Too
semgrepCmd := createCommand(configurationFile, toolExecution.SourceDir, language, files)

semgrepOutput, semgrepError, err := runCommand(semgrepCmd)
if err != nil {
return nil, errors.New("Error running semgrep: " + *semgrepError + "\n" + err.Error())

// Try to parse output if we have any
if semgrepOutput != nil && *semgrepOutput != "" {
output, parseErr := parseCommandOutput(patternDescriptions, *semgrepOutput)
if parseErr != nil {
// If parsing fails and we had a command error, report the command error
if err != nil {
return nil, errors.New("Error running Opengrep: " + *semgrepError + "\n" + err.Error())
}
return nil, parseErr
}
// Parsing succeeded, return results even if command had a non-zero exit
if err != nil {
fmt.Printf("Warning: Opengrep exited with error (some files may not have been analyzed): %v\n", err)
}
return output, nil
}

output, err := parseCommandOutput(patternDescriptions, *semgrepOutput)
// No output and command failed
if err != nil {
return nil, err
return nil, errors.New("Error running Opengrep: " + *semgrepError + "\n" + err.Error())
}
return output, nil

// No output but command succeeded - return empty results
return []codacy.Result{}, nil
}

func createCommand(configurationFile *os.File, sourceDir, language string, files []string) *exec.Cmd {
Expand Down Expand Up @@ -105,15 +121,18 @@ func createCommandParameters(language string, configurationFile *os.File, filesT
}

func runCommand(cmd *exec.Cmd) (*string, *string, error) {
var stdout bytes.Buffer
var stderr bytes.Buffer
cmd.Stdout = &stdout
cmd.Stderr = &stderr
cmdOutput, err := cmd.Output()
if err != nil {
stderrString := stderr.String()
return nil, &stderrString, err
}
cmdOutputString := string(cmdOutput)
return &cmdOutputString, nil, nil

err := cmd.Run()

stdoutString := stdout.String()
stderrString := stderr.String()

// Return output regardless of error - the caller can decide what to do
return &stdoutString, &stderrString, err
}

func parseCommandOutput(patternDescriptions *[]codacy.PatternDescription, commandOutput string) ([]codacy.Result, error) {
Expand Down Expand Up @@ -180,6 +199,11 @@ func getMessage(patternDescriptions *[]codacy.PatternDescription, id string, ext

func appendErrorToResult(result []codacy.Result, semgrepOutput SemgrepOutput) []codacy.Result {
for _, semgrepError := range semgrepOutput.Errors {
// Skip errors with empty paths (e.g., from symlinks that couldn't be analyzed)
if semgrepError.Location.Path == "" {
continue
}

// Determine the size of the error message we're logging
sizeMessage := 250

Expand Down