Skip to content

Batch files passed to opengrep to avoid ARG_MAX errors TAR-87 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
machadoit merged 2 commits into from
Sep 21, 2026
Merged

Batch files passed to opengrep to avoid ARG_MAX errors TAR-87 #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57cddc3
Batch files passed to opengrep to avoid ARG_MAX errors
lolgab Sep 17, 2026
92aae53
Change batch to 1k files
machadoit Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 32 additions & 8 deletions internal/tool/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,43 @@ type SemgrepErrorLocation struct {
Path string `json:"path"`
}

// maxFilesPerBatch caps how many files get passed as CLI args per opengrep
// invocation, to avoid hitting the OS argument list size limit (ARG_MAX)
// on repos with a very large number of files.
const maxFilesPerBatch = 1000

func executeCommandForFiles(configurationFile *os.File, toolExecution codacy.ToolExecution, patternDescriptions *[]codacy.PatternDescription, language string, files []string) ([]codacy.Result, error) {
semgrepCmd := createCommand(configurationFile, toolExecution.SourceDir, language, files)
var results []codacy.Result

semgrepOutput, semgrepError, err := runCommand(semgrepCmd)
if err != nil {
return nil, errors.New("Error running semgrep: " + *semgrepError + "\n" + err.Error())
for _, batch := range chunkFiles(files, maxFilesPerBatch) {
semgrepCmd := createCommand(configurationFile, toolExecution.SourceDir, language, batch)

semgrepOutput, semgrepError, err := runCommand(semgrepCmd)
if err != nil {
return nil, errors.New("Error running semgrep: " + *semgrepError + "\n" + err.Error())
}

output, err := parseCommandOutput(patternDescriptions, *semgrepOutput)
if err != nil {
return nil, err
}
results = append(results, output...)
}

output, err := parseCommandOutput(patternDescriptions, *semgrepOutput)
if err != nil {
return nil, err
return results, nil
}

func chunkFiles(files []string, size int) [][]string {

@machadoit machadoit Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it easy to make unit test of this? Are there any? Maybe is overkill, but I see this type of code and always think on off by one errors

if len(files) == 0 {
return nil
}

var chunks [][]string
for start := 0; start < len(files); start += size {
end := min(start+size, len(files))
chunks = append(chunks, files[start:end])
}
return output, nil
return chunks
}

func createCommand(configurationFile *os.File, sourceDir, language string, files []string) *exec.Cmd {
Expand Down