Repository navigation
Clean up orphaned test volumes during onboarding - #385
Merged
Merged
Conversation
Aborted smoke test builds (e.g. volume quota exceeded) leave their boot volumes behind in the test project. Once the project exhausts its volume quota, every subsequent onboarding fails with VolumeLimitExceeded and the host is stuck. The onboarding controller now sweeps the test project for orphaned volumes after a test server ends up in error state and before creating a new test server. A volume is only deleted when it is unattached, named after an instance UUID, and no instance with that ID exists in the project anymore. Signed-off-by: Andrew Karpow <andrew.karpow@sap.com>
Merging this branch will increase overall coverage
Coverage detailsCompared to commit c4c8979 (run #41664443347)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
mchristianl
approved these changes
Nov 3, 2026
fwiesel
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aborted smoke test builds leave their boot volumes behind in the test project; once the project exhausts its volume quota, every subsequent onboarding of that host fails with VolumeLimitExceeded and stays stuck.
The onboarding controller now sweeps the test project for orphaned volumes after a test server ends up in error state and before creating a new test server. A volume is deleted only when it is unattached, named after an instance UUID, and no instance with that ID exists in the project anymore.