Repository navigation
feat: implement CRC rollback on failure and dry-run cleanup - #1463
Open
juliusclausnitzer wants to merge 8 commits into
Open
juliusclausnitzer wants to merge 8 commits into
juliusclausnitzer wants to merge 8 commits into
Conversation
Signed-off-by: juliusclausnitzer <julius.clausnitzer@sap.com>
![cortex-ai-agents[bot]](https://avatars.githubusercontent.com/in/3521331?s=60&v=4){kind=small}
juliusclausnitzer
marked this pull request as ready for review
November 4, 2026 13:33
juliusclausnitzer
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
mblos and
umswmayj
as code owners
November 4, 2026 13:33
Signed-off-by: juliusclausnitzer <julius.clausnitzer@sap.com>
Contributor
Test Coverage ReportTest Coverage 📊: 71.9% |
juliusclausnitzer
changed the title
juliusclausnitzer
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reconcileRollingBackandreconcileDryRunCleanupFSM phase handlersrestoreFromSnapshothelper: two-pass write→settle loop, idempotent and crash-safeterminateWithRollbackFailedwith aphaseparameter — DryRunCleanup timeouts terminate asAccepted(schedulability verdict preserved), RollingBack timeouts asRejectedRollbackStartedAt *metav1.Timeto CRC status to measure rollback timeout from phase entry rather thanProgressing.LastTransitionTime(only updates on status flips, not reason-only changes)