Skip to content

ci(linkchecker): declare contents: read - #130

Closed
arpitjain099 wants to merge 1 commit into
cncf:mainfrom
arpitjain099:ci/add-permissions
Closed

ci(linkchecker): declare contents: read#130
arpitjain099 wants to merge 1 commit into
cncf:mainfrom
arpitjain099:ci/add-permissions

Conversation

@arpitjain099

Copy link
Copy Markdown

Pins the default GITHUB_TOKEN for the only workflow here. lycheeverse/lychee-action uses the token solely to raise lychee's github.com rate limit (read-only API), so contents: read is sufficient.

YAML validated locally.

@arpitjain099

Copy link
Copy Markdown
Author

Hi @rochaporto, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback.

@arpitjain099

Copy link
Copy Markdown
Author

Hey, Pinging gently. Let me know if there's a path forward or if I should close it. Thanks for your time.

lychee uses GITHUB_TOKEN to raise its github.com rate limit; the
workflow does not need write access.

Signed-off-by: arpitjain099 <arpitjain099@gmail.com>
@arpitjain099

Copy link
Copy Markdown
Author

Closing this. Going to rebase it I found that .github/workflows/linkchecker.yaml no longer exists on main, so there is nothing left for the change to apply to. Thanks for the approval back in June regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants