Repository navigation
Conversation
…e 2025-11-19 block Five rows in the 2025-11-19 weight block carry the 2024-11-19 reference date, so that week's climate_linear ensemble silently drops their mass (the loader treats them as a separate stale block). Fix the dates so the block is internally consistent. Fixes cmu-delphi#214
Contributor
|
Thank you for the help, we have this fix in #233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: five rows inside the 2025-11-19 ensemble-weight block of
scripts/flu_geo_exclusions.csvcarry the 2024-11-19 reference date, so the loader treats them as a separate stale block and that week'sclimate_linearensemble silently loses their mass.Evidence: parsed and re-verified against the loader logic (
utils.Rweight parsing); exactly 5 rows change — the reference-date column only, nothing else.Change: correct the five dates 2024-11-19 → 2025-11-19 (5-line diff,
git apply --checkandpatch -p1both verified against current main).Fixes #214