Skip to content

Detect archive version dates represented with midnight UTC POSIXct, c… - #753

Merged
brookslogan merged 3 commits into
devfrom
lcb/epidatr-dates-as-datetimes-compat
Oct 5, 2026
Merged

brookslogan merged 3 commits into
devfrom
lcb/epidatr-dates-as-datetimes-compat

Conversation

@brookslogan

@brookslogan brookslogan commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

…onvert

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • Styling and documentation checks. Make a PR comment with:
    • /style to check the style and fix any issues.
    • /document to check the package documentation and fix any issues.
    • /preview-docs to preview the docs.
    • See Actions GitHub tab to track progress of these commands.
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

This makes as_epi_archive convert midnight UTC POSIXct datetime versions into dates, as this seems a fairly uncontroversial conversion and it seems there is not a settled path forward on API/epidatr handling of these coming out of epidata_archive().

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@JavierMtzRdz JavierMtzRdz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. It seems like the right thing to do while the cast-api change is being resolved. For reference, this is the cast-api PR that keeps the date consistent across every zone from UTC-12 to UTC+11 https://github.com/cmu-delphi/cast-api/pull/134

Comment thread R/archive.R Resolved
@brookslogan
brookslogan force-pushed the lcb/epidatr-dates-as-datetimes-compat branch from 5932bde to 785d1bf Compare October 5, 2026 10:38
@brookslogan
brookslogan merged commit 9bd5ab8 into dev Oct 5, 2026
6 checks passed
@brookslogan
brookslogan deleted the lcb/epidatr-dates-as-datetimes-compat branch October 5, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert dates represented as midnight-UTC datetimes back to dates in constructors

2 participants