Repository navigation
Detect archive version dates represented with midnight UTC POSIXct, c… - #753
Merged
Merged
Conversation
JavierMtzRdz
approved these changes
Oct 2, 2026
JavierMtzRdz
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this. It seems like the right thing to do while the cast-api change is being resolved. For reference, this is the cast-api PR that keeps the date consistent across every zone from UTC-12 to UTC+11 https://github.com/cmu-delphi/cast-api/pull/134
brookslogan
force-pushed
the
lcb/epidatr-dates-as-datetimes-compat
branch
from
October 5, 2026 10:38
5932bde to
785d1bf
Compare
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onvert
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
/styleto check the style and fix any issues./documentto check the package documentation and fix any issues./preview-docsto preview the docs.process.
Change explanations for reviewer
This makes
as_epi_archiveconvert midnight UTC POSIXct datetime versions into dates, as this seems a fairly uncontroversial conversion and it seems there is not a settled path forward on API/epidatr handling of these coming out ofepidata_archive().Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch