Repository navigation
benchmarks: measure all revisions in the same run - #735
Merged
Merged
Conversation
Results from different runs do not compare: each run gets a runner in any region, and the same release code measured 1.78x slower in one run than in the next. Since each commit was measured once and kept, the dashboard mixed runners and showed spikes unrelated to the code. Measure every release and every commit since the latest release in each run, without restoring previous results. The run gets longer as commits accumulate until the next release, so raise the timeout to 4 hours. Signed-off-by: Stephane Thiell <stephane@thiell.com>
degremont
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results from different runs don't compare: the same release code measured 1.78x slower in one run than in the next (runners in different regions). Since #733 kept each commit's first measurement, the dashboard mixed runs, hence the spikes. Measure instead all releases and every commit since the latest release in each run, without restoring previous results; timeout raised to 4 hours.
Dry run on my fork: 53 revisions in 1h13, output at https://thiell.github.io/clustershell-benchmarks/
Follow-up to #733.