Skip to content

Fix build_track failure with Lavalink v4 decodetrack format#66

Merged
cloudwithax merged 5 commits into
cloudwithax:mainfrom
ZandercraftGames:main
Mar 13, 2024
Merged

Fix build_track failure with Lavalink v4 decodetrack format#66
cloudwithax merged 5 commits into
cloudwithax:mainfrom
ZandercraftGames:main

Conversation

@ZandercraftGames

Copy link
Copy Markdown
Contributor

Lavalink v4 made some changes to the format returned by decodetrack. This update resolves those issues by adding a check for Lavalink v4 and using the new format appropriately in the build_track function which currently fails with a KeyError.

@ZandercraftGames

Copy link
Copy Markdown
Contributor Author

Okay haha. Guess pre-commit.ci disagrees with Python Black format. 🤷‍♂️

@NiceAesth

Copy link
Copy Markdown
Contributor

Okay haha. Guess pre-commit.ci disagrees with Python Black format. 🤷‍♂️

#62

Comment thread pomice/pool.py Outdated

@NiceAesth NiceAesth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@cloudwithax

Copy link
Copy Markdown
Owner

LGTM

@cloudwithax cloudwithax merged commit 519a14f into cloudwithax:main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants