security: bump setuptools build requirement to >=83.0.0 - #7
Merged
Merged
Conversation
Fixes all 4 open Dependabot alerts (setuptools < 65.5.1, < 70.0.0, < 78.1.1, < 83.0.0) attributed to requirements-rtd.txt. The vulnerable pin setuptools==44.0.0 lives in pyproject.toml [build-system].
There was a problem hiding this comment.
Summary
This change is correct and appropriately scoped: it updates the build-system setuptools requirement from a vulnerable hard pin (==44.0.0) to a patched floor (>=83.0.0) in pyproject.toml.
I found no concrete regressions in correctness, security, or build contract from the provided diff. For a build backend requirement, a minimum bound is the right shape to keep security posture while allowing compatible newer releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security bumps
pyproject.toml(build-system)==44.0.0->>=83.0.0requirements-rtd.txt)All four open Dependabot alerts for this repo are setuptools vulnerabilities; the vulnerable pin (
setuptools==44.0.0) lives in the[build-system]requires ofpyproject.toml, which the dependency graph attributes to therequirements-rtd.txtmanifest. Raising the requirement to>=83.0.0satisfies every first-patched threshold (65.5.1, 70.0.0, 78.1.1, 83.0.0).Validation
uv build(isolated PEP 517 build with setuptools >= 83): sdist + wheel build successfully (thumbor_video_engine-1.2.5).Notes
test.ymlusesactions/upload-artifact@v3/actions/download-artifact@v3, which GitHub now auto-fails (deprecated artifact actions v3). Per campaign rules,.github/workflows/*is not editable, so this cannot be fixed in this PR. The same failure is visible on Dependabot's own PR Bump setuptools from 44.0.0 to 83.0.0 #6.