Skip to content

enha: configurable max gas limit for calls and transactions - #2722

Open
carneiro-cw wants to merge 1 commit into
mainfrom
max_gas
Open

carneiro-cw wants to merge 1 commit into
mainfrom
max_gas

Conversation

@carneiro-cw

Copy link
Copy Markdown
Contributor

No description provided.

@carneiro-cw
carneiro-cw requested a review from a team as a code owner September 30, 2026 18:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T18:33:34.211969Z 4f936ec PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudwalk-review-agent cloudwalk-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Looks good overall. The change cleanly replaces the hardcoded global gas cap with configurable per-execution caps (transaction_max_gas_limit and call_max_gas_limit), threads those values through EVM env construction, and updates config shape/docs/tests consistently.

I did not find concrete correctness or safety regressions in the provided diff. The inspector path also consistently uses the transaction cap as intended by the inline comment.

@github-actions

Copy link
Copy Markdown
Contributor

Failed to generate code suggestions for PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f936ecddc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/eth/executor/config.rs
Comment thread src/eth/executor/config.rs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants