feat: Add renderCustomTrigger prop to Select#4589
Draft
taheramr wants to merge 1 commit into
Draft
Conversation
Adds a public `renderCustomTrigger` prop on Select that lets consumers fully replace the default trigger element while Select retains ownership of the dropdown lifecycle, focus return, ARIA wiring, and form-field integration.
The `SelectProps.CustomTriggerProps` props bag exposes:
- `triggerRef` — attach to the focusable element so Select can return focus on close
- `isOpen` — current dropdown state
- `onClick` — toggles the dropdown open/closed
- `ariaProps` — { id, 'aria-expanded', 'aria-labelledby', 'aria-describedby', 'aria-required' } to spread on the focusable element
The consumer is responsible for rendering `aria-haspopup="listbox"` on the focusable element themselves (fixed value, not in the bag).
When `renderCustomTrigger` is provided, the `placeholder` prop is not consumed by Select — the consumer renders their own empty state.
Test utilities:
- New `findCustomTrigger()` returns the wrapper around the consumer's custom trigger; null for default Select.
- Existing `findTrigger()` is unchanged for default Select; returns null when `renderCustomTrigger` is provided.
Backward compatible: default Select behavior is unchanged when the new prop is not provided.
Refs: AWSUI-61998
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a public
renderCustomTriggerprop on Select that lets consumers fully replace the default trigger element while Select retains ownership of the dropdown lifecycle, focus return, ARIA wiring, and form-field integration.The
SelectProps.CustomTriggerPropsprops bag exposes:triggerRef— attach to the focusable element so Select can return focus on closeisOpen— current dropdown stateonClick— toggles the dropdown open/closedariaProps— { id, 'aria-expanded', 'aria-labelledby', 'aria-describedby', 'aria-required' } to spread on the focusable elementThe consumer is responsible for rendering
aria-haspopup="listbox"on the focusable element themselves (fixed value, not in the bag).When
renderCustomTriggeris provided, theplaceholderprop is not consumed by Select — the consumer renders their own empty state.Test utilities:
findCustomTrigger()returns the wrapper around the consumer's custom trigger; null for default Select.findTrigger()is unchanged for default Select; returns null whenrenderCustomTriggeris provided.Backward compatible: default Select behavior is unchanged when the new prop is not provided.
Refs: AWSUI-61998
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.