Implement Default for StreamRenderer - #2
Open
Atliac wants to merge 1 commit into
Open
Conversation
Provide a default implementation that uses the current terminal width and automatic theme mode, simplifying the initialization of the StreamRenderer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
DefaultforStreamRendererDescription
This PR introduces a
Defaultimplementation for theStreamRendererstruct, allowing for a more ergonomic initialization process.Motivation
Previously, creating a
StreamRendererrequired explicitly providing the terminal width and aThemeMode. By implementingDefault, the renderer can now automatically detect the current terminal width and set the theme toAuto, reducing boilerplate for users who want standard behavior.Changes
src/stream_renderer.rs: Addedimpl Default for StreamRendererwhich initializes the renderer usingcurrent_terminal_width()andThemeMode::Auto.examples/streaming_demo.rs: Updated the example to useStreamRenderer::default()instead of a hardcoded width and theme.Testing
examples/streaming_demo.rsruns correctly using the newdefault()initialization.