Skip to content

Enable the new module registry by default from 2026-11-01 #7799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
irvinebroque wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable the new module registry by default from 2026-11-01 #7799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/workerd/io/compatibility-date-test.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,8 +590,7 @@ KJ_TEST("encode to full flag list") {
}

KJ_TEST("compatibility dates must be Tuesday, Wednesday, or Thursday") {
// List of specific flags that are allowed to use non-conformant dates
// (already deployed and can't be changed for compatibility reasons)
// Specific flags with compatibility dates outside the normal release weekdays.
kj::HashSet<kj::StringPtr> allowedFlagExceptions;
allowedFlagExceptions.insertAll(std::initializer_list<kj::StringPtr>{
// Existing non-conformant dates that are already deployed
Expand Down Expand Up @@ -649,6 +648,9 @@ KJ_TEST("compatibility dates must be Tuesday, Wednesday, or Thursday") {
"pythonWorkers20250116"_kj, // 2025-09-29 (Monday) via impliedByAfterDate
"removeNodejsCompatEOLv22"_kj, // 2027-04-30 (Friday) via impliedByAfterDate
"removeNodejsCompatEOLv24"_kj, // 2028-04-30 (Sunday) via impliedByAfterDate

// Scheduled default enablement on November 1, 2026 (Sunday).
"newModuleRegistry"_kj,
});

// Helper function to suggest the next valid date (Tuesday, Wednesday, or Thursday)
Expand Down
3 changes: 2 additions & 1 deletion src/workerd/io/compatibility-date.capnp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Copyright (c) 2017-2022 Cloudflare, Inc.
# Licensed under the Apache 2.0 license found in the LICENSE file or at:
# https://opensource.org/licenses/Apache-2.0
Expand Down Expand Up @@ -513,7 +513,8 @@

newModuleRegistry @52 :Bool
$compatEnableFlag("new_module_registry")
$compatDisableFlag("legacy_module_registry");
$compatDisableFlag("legacy_module_registry")
$compatEnableDate("2026-11-01");
# Enables the new module registry implementation, which handles module
# specifiers as URLs, implements import.meta (url/main/resolve), supports
# import attributes, and allows a registry to be shared across isolate
Expand Down
3 changes: 0 additions & 3 deletions src/workerd/server/factory/worker-factory.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,9 +1569,6 @@ kj::Promise<kj::Own<CompiledWorker>> factory_new_worker(const WorkerFactory& con
bool usingNewModuleRegistry = isNewModuleRegistryEnabled(featureFlags);
kj::Maybe<kj::Arc<jsg::modules::ModuleRegistry>> newModuleRegistry;
if (usingNewModuleRegistry) {
KJ_REQUIRE(experimental,
"The new ModuleRegistry implementation is an experimental feature. "
"You must run workerd with `--experimental` to use this feature.");
// Module URLs follow the virtual file system: a module at "/foo/bar/baz.js" in the bundle
// is "file:///foo/bar/baz.js".
const jsg::Url& bundleBase = workerFs->getBundleRoot();
Expand Down
Loading