Repository navigation
Conversation
|
Since last review: 0 resolved, 0 still open, 0 new. Not re-run: tests, docs, compat-flags, design-simplicity, kj-style, memory-safety, rust-first (no author changes in their files since the last review) Reviewed commit: 563c979f · github run |
9a8fe98 to
8cd9e9c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7528 +/- ##
==========================================
- Coverage 41.82% 41.79% -0.03%
==========================================
Files 1015 1017 +2
Lines 292015 292254 +239
Branches 28198 28198
==========================================
+ Hits 122133 122147 +14
- Misses 153387 153613 +226
+ Partials 16495 16494 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8cd9e9c to
b28f3c0
Compare
| ) | ||
|
|
||
| selects.config_setting_group( | ||
| name = "really_use_rust_perfetto", |
There was a problem hiding this comment.
This is kind of funny but I don't quite get why we need this really option.
npaun
left a comment
There was a problem hiding this comment.
Looks perfetto to me once the Bonk issues are addressed. My clanker also brings up the exact same concerns. No further concerns from me as a human.
0b2f792 to
c490e23
Compare
|
💬 Approved with comments — No correctness or security problems found. The only item is an INFO note about per-event locking and allocation in the enabled Rust tracing backend, which costs nothing unless a tracing session is active. Findings: 1 info The decision is advisory: this comment never approves, blocks or requests changes on the pull request. 🔧 Fix with your agentPaste the following into your coding agent to investigate and fix these issues. ⚡ Performance: 💬 1 infoNo hot-path regressions; one note on per-event cost while tracing is enabled Recommendation: 💬 Optional Nits
View full review
✅ All other checks passed🔒 Security: ✅ LGTMThis is internal tracing plumbing: a patch to the Perfetto build, a Rust SDK wrapper and a cxx bridge. None of it is reachable from user input. 📖 AGENTS.md: ✅ LGTMThe AGENTS.md updates in the root, 📋 Code Quality: ✅ LGTMThe Bazel select gating, the cfg-gated enabled and disabled backends, and the tests are consistent. 📝 Documentation: ✅ LGTMThe documentation updates in Reviewed commit: |
Make perfetto available to rust
c490e23 to
563c979
Compare
Make perfetto available to rust