Repository navigation
Internal build for #7470 - #7489
Merged
1 commit merged intoSep 23, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
The HTML spec declares `MessageEventSource? source = null` in MessageEventInit, but the initializer typed source as jsg::Optional<jsg::Ref<MessagePort>>, which rejects null with a TypeError. Message events fired by a WebSocket or an EventSource have a null source, so copying one with `new MessageEvent(event.type, event)` threw. partysocket copies events that way. Compatibility: no flag. An omitted source and a MessagePort source behave as before; the only change is that null no longer throws. Before 79e36b4 the initializer read nothing but data, so code passing a null source worked until then, and this restores that.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal build for #7470