Repository navigation
[Durable Objects] Type the SQL greeting query result - #34423
Merged
Merged
Conversation
phocks
requested review from
a team,
danlapid,
iglesiasbrandon,
irvinebroque,
joshthoward,
lambrospetrou,
rita3ko and
vy-ton
as code owners
October 17, 2026 10:35
github-actions
Bot
added
the
product:durable-objects
Contributor
AI Review✅ Reviewed Resolved (1) · Dismissed (0)
Commands
|
irvinebroque
changed the title
irvinebroque
approved these changes
Oct 18, 2026
irvinebroque
left a comment
irvinebroque
left a comment
Contributor
There was a problem hiding this comment.
Verified workerd SqlStorage.exec() and SqlStorageCursor.one(): the explicit greeting:string row type matches this SELECT string literal and makes sayHello return a string. After updating from production, the one-line change is identical to the reviewed diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor docs edit. Accept or don't, but it will probably come up again if others are using TypeScript to follow this tute.