Repository navigation
Conversation
madhugb
requested review from
a team,
akshitsinha,
irvinebroque,
ishita1805 and
vaibhavshn
as code owners
October 16, 2026 09:02
Contributor
AI Review✅ Reviewed Resolved (1) · Dismissed (0)
Commands
|
Contributor
Review coverage✅ All 2 ownership areas are covered. ✅ 2 areas already covered
CODEOWNERS mappings for displayed areas (2)
|
akshitsinha
approved these changes
Oct 16, 2026
| | Serialized UTF-8 JSON size | 32 KiB | All evaluation paths | | ||
| | Values visited during traversal | 10,000 values | Data-plane HTTP and Workers binding only | | ||
|
|
||
| Flagship control-plane `POST` endpoints do not apply the 10,000-value traversal limit. Other context limits still apply. |
Member
There was a problem hiding this comment.
Potential follow-up: shouldn't POST also have traversal limits?
akshitsinha
reviewed
Oct 16, 2026
| @@ -41,7 +41,8 @@ The binding provides type-safe methods for evaluating feature flags. If an evalu | |||
| export default { | |||
| async fetch(request: Request, env: Env): Promise<Response> { | |||
| const enabled = await env.FLAGS.getBooleanValue("new-feature", false, { | |||
| userId: "user-42", | |||
Member
There was a problem hiding this comment.
Could we retain userId along with the rest of the JSON context fields we added? Would be helpful for folks who just want to provide a simple string or number as context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents structured (JSON) evaluation context support and the Flagship evaluation API:
New page
flagship/reference/evaluation-api.mdx— the data-plane evaluation API, coveringGETwith scalar query context andPOSTwith structured JSON context, including an<APIRequest>example.Structured context in the Workers binding — recursive values (nested objects, arrays,
null),Datenormalization to ISO 8601, rejection of non-finite numbers and cyclic values, and the resultingINVALID_CONTEXTerror. Documents the recursive public context declarations and how to serializeDatevalues for TypeScript.Two new targeting operators —
hasandnot_has(11 → 13) added to the operators reference, targeting overview, and Wrangler--ruleexamples.Dot-path attribute traversal — up to five segments, with literal top-level key precedence — documented in targeting rules and percentage rollout bucketing.
Evaluation context limits — attribute count, key length, nesting depth, serialized size, and traversal count — added to the limits reference.
errorMessagefield onFlagshipEvaluationDetails, plus new invalid-context behavior docs: binding*Details()methods return the default value with error fields, while the HTTPPOSTendpoint returns400.Context support matrix on the SDK index covering structured context through the direct binding, evaluation API
POST, and TypeScript, Python, and Go SDKs from version0.6.0. The SDKs automatically usePOSTfor structured HTTP context; Wrangler--contextvalues remain strings.Clarifies across Wrangler and SDK pages that JSON-looking query values remain strings and do not create nested context.
Changelog — adds
flagship/2026-10-23-structured-evaluation-context.mdx, dated Friday, October 23, covering nested targeting, array membership, and SDK support.Documentation checklist