Skip to content

fix: allow 50-second Worker profiling captures to finish - #257

Merged
petebacondarwin merged 2 commits into
cloudflare:mainfrom
irvinebroque:bib/profiling-api-timeout
Oct 12, 2026
Merged

petebacondarwin merged 2 commits into
cloudflare:mainfrom
irvinebroque:bib/profiling-api-timeout

Conversation

@irvinebroque

@irvinebroque irvinebroque commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Workers profiling supports captures up to 50 seconds, but cf workers versions profile currently aborts them after 30 seconds. Profiling sends a JSON body and downloads binary data, so the binary-upload exemption from #115 does not apply.

This raises the default API timeout to 60 seconds, giving a 50-second capture 10 seconds of additional request budget.

cf workers versions profile latest \
  --worker-id "$WORKER_ID_OR_NAME" \
  --duration-ms 50000 \
  --profile-type cpu > worker-cpu.pprof.gz

@github-actions

Copy link
Copy Markdown
Contributor

Hi @irvinebroque. Thanks for contributing to cf!

During the open beta, we’re being very intentional about the changes we accept so that we can prioritise stability for GA. We’re limiting pull requests to contributions coordinated with the team in advance, so this PR has been automatically closed.

We’d still love to hear about your use case, so please make sure it’s captured in a cf issue. If the proposed change fits our priorities, we’d be happy to take another look at this PR.

@pkg-pr-new

pkg-pr-new Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/cf@257

commit: 56481a7

@penalosa
penalosa marked this pull request as ready for review October 12, 2026 09:58
@penalosa
penalosa requested a review from a team as a code owner October 12, 2026 09:58
@penalosa
penalosa requested a review from jamesopstad October 12, 2026 09:58
@penalosa
penalosa force-pushed the bib/profiling-api-timeout branch from 398725b to 56481a7 Compare October 12, 2026 09:58
@petebacondarwin
petebacondarwin added this pull request to the merge queue Oct 12, 2026
Merged via the queue into cloudflare:main with commit 8747bd9 Oct 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants