Repository navigation
refactor: remove x-forge-globals and globalCliArgs - #250
Draft
dimitropoulos wants to merge 2 commits into
Draft
dimitropoulos wants to merge 2 commits into
dimitropoulos wants to merge 2 commits into
Conversation
Contributor
|
LGTM |
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only change accurately reflects cloudflare/forge#25.
0 open findings
What changed in this PR
Removes obsolete x-forge-globals documentation following its removal from Forge.
Changes:
- Deletes
x-forge-globalsfrom the supported extension table.
| File | Description |
|---|---|
AGENTS.md |
Removes the obsolete extension entry. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
commit: |
Forge no longer has Schema.command.globalCliArgs. Re-vendor @cloudflare/forge with that change and stop setting the field.
dimitropoulos
changed the title
Contributor
|
LGTM |
Contributor
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 155.2 ms | 3.4 ms | 150.3 ms | 165.6 ms |
| base | 151.3 ms | 4.1 ms | 146.1 ms | 163.2 ms |
Δ (PR vs base): ↑ +4.0 ms (+2.6%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
Collaborator
|
Blocked on cloudflare/forge#25 being merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches cloudflare/forge#25, which removes the
x-forge-globalsextension andSchema.command.globalCliArgs.@cloudflare/forgefrom that branch. The only difference from the current tarball is the removal, andpnpm-lock.yamlgets the new integrity hash.@cloudflare/forge-transformer-sdk-tsdoesn't change.globalCliArgs: []fields cf set on command roots and test fixtures.x-forge-globalsrow from the extension table inAGENTS.md.check:type,check:lint, andcheck:formatpass. Inpackages/clitests, 1506 pass. The 4local-e2e.test.tsfailures are timeouts that also happen onmainlocally.Merge after cloudflare/forge#25.