Repository navigation
Release 5.4.0 - #546
Release 5.4.0#546
Conversation
There was a problem hiding this comment.
💬 Approved with comments — The version bump is consistent across the workspace and the release notes are updated. The only comment is a non-blocking suggestion about out-of-order dates in the release notes.
Findings: 1 suggestion
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
🚀 Release: 💬 1 suggestion
Version bump is consistent; one minor release-notes ordering nit
Recommendation: 💬 Optional Nits
- [SUGGESTION] RELEASE_NOTES 5.4.0 section: two entries dated 2026-03-27 sit between October entries, out of the newest-first order the other entries follow. They are probably author dates of older commits; consider reordering them or using the merge dates. (
RELEASE_NOTES:6)
View full review
Risk: Low
The workspace version and the boring-sys/boring/tokio-boring dependency versions in Cargo.toml are all bumped from 5.3.0 to 5.4.0. RELEASE_NOTES gains a 5.4.0 section. Two entries are dated 2026-03-27 and sit between October entries, out of the newest-first order the other entries follow. The release scope could not be compared against the previous tag because tag history is not available here.
Reviewed commit: a9c6c387
No description provided.