two microoptimizations

Author: dnolen

src/main/clojure/cljs/analyzer.cljc

@@ -1600,7 +1600,7 @@
            (every? constant-value? (ast-children ast)))))
 
 (defn const-expr->constant-value [{:keys [op] :as e}]
-  (case op 
+  (case op
     :quote  (const-expr->constant-value (:expr e))
     :const  (:val e)
     :map    (zipmap (map const-expr->constant-value (:keys e))
@@ -1926,7 +1926,7 @@
                        {:protocol-impl proto-impl
                         :protocol-inline proto-inline})
         methods      (map #(disallowing-ns* (analyze-fn-method menv locals % type (nil? name))) meths)
-        mfa          (apply max (map :fixed-arity methods))
+        mfa          (transduce (map :fixed-arity) max 0 methods)
         variadic     (boolean (some :variadic? methods))
         locals       (if named-fn?
                        (update-in locals [name] assoc

src/main/clojure/cljs/compiler.cljc

@@ -205,7 +205,8 @@
      #?(:clj (map? x) :cljs (ana/cljs-map? x)) (emit x)
      #?(:clj (seq? x) :cljs (ana/cljs-seq? x)) (apply emits x)
      #?(:clj (fn? x) :cljs ^boolean (goog/isFunction x)) (x)
-     :else (let [s (print-str x)]
+     :else (let [s (cond-> x
+                     (not (string? x)) print-str)]
              (when-not (nil? *source-map-data*)
                (swap! *source-map-data*
                  update-in [:gen-col] #(+ % (count s))))

src/test/clojure/cljs/profile.clj

@@ -0,0 +1,21 @@
+(ns cljs.profile
+  (:require [clojure.java.io :as io]
+            [cljs.env :as env]
+            [cljs.analyzer :as ana]
+            [cljs.compiler :as comp]))
+
+(comment
+
+  ;; ~900ms
+  (dotimes [_ 20]
+    (time (ana/analyze-file (io/resource "cljs/core.cljs"))))
+
+  ;; ~2700ms
+  ;; after change ~2500
+  (dotimes [_ 20]
+    (time
+      (env/with-compiler-env (env/default-compiler-env)
+        (comp/compile-file (.getPath (io/resource "cljs/core.cljs")))
+        (.delete (io/file "src/main/cljs/cljs/core.js")))))
+
+  )