CLJS-2861: Self-host: :checked-arrays not working

Author: mfikes

src/main/clojure/cljs/analyzer.cljc

@@ -2267,7 +2267,7 @@
             (throw (error env "set! target must be a field or a symbol naming a var")))
           (cond
             (and (not (:def-emits-var env))                 ;; non-REPL context
-                 (some? ('#{*unchecked-if* *unchecked-array* *warn-on-infer*} target)))
+                 (some? ('#{*unchecked-if* *unchecked-arrays* *warn-on-infer*} target)))
             {:env env :op :no-op}
 
             :else

src/test/cljs/cljs/array_access_test.cljs

@@ -11,6 +11,12 @@
   (:require [cljs.test :as test :refer [deftest is]]
             [cljs.array-access.alpha :as alpha]))
 
+(deftest cljs-2861-test
+  ;; With cljs-2718, a typo led to (set! *unchecked-arrays* true) as
+  ;; not being treated as a no-op generating intrisic, which we can
+  ;; detect here when this test is run in JVM ClojureScript.
+  (is (false? *unchecked-arrays*)))
+
 (deftest unchecked-arrays-file-scope-test
   (is (not (alpha/unchecked-arrays?))))