Skip to content

Fixed project owner changes from organization to member - #2247

Merged
HaraldWalker merged 10 commits into
masterfrom
fix-project-owner-problem-after-edit
Sep 8, 2026
Merged

Fixed project owner changes from organization to member#2247
HaraldWalker merged 10 commits into
masterfrom
fix-project-owner-problem-after-edit

Conversation

@fateme-ramezanpour

@fateme-ramezanpour fateme-ramezanpour commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Description

This PR addresses issue 2070

Checked the following

  • Pages affected by this change work on mobile
  • Pages affected by this change work when logged out
  • Pages affected by this change work when logged in
  • Pages affected by this change work with custom theme and default theme

What and Why

@fateme-ramezanpour fateme-ramezanpour changed the title fixed the problem Fixed project owner changes from organization to member Aug 25, 2026
@fateme-ramezanpour
fateme-ramezanpour marked this pull request as ready for review August 25, 2026 11:13
@HaraldWalker
HaraldWalker deployed to pull_request August 26, 2026 10:02 — with GitHub Actions Active
@HaraldWalker

Copy link
Copy Markdown
Contributor

Two tests from the specs have not been implemented and this is a good moment to refactor the test as it is already too large.

test_project_views.py is 2115 lines with inconsistent grouping. I recommend refactoring it into separate files:

  • Collection/list endpoints (get projects, filter, similar projects)
  • CRUD operations on a single project (GET by slug, PATCH edit, DELETE)

The new edit-project ownership tests should go in the CRUD file. This makes the tests easier to navigate and maintain.
As a next step (out of scope for this bug fix) we could then also split the view along the same lines.

@HaraldWalker HaraldWalker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looking good. Requesting some code quality changes.

@HaraldWalker
HaraldWalker merged commit 321610c into master Sep 8, 2026
3 checks passed
@HaraldWalker
HaraldWalker deleted the fix-project-owner-problem-after-edit branch September 8, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants