Repository navigation
Fix shortest-only completion at an empty root prompt - #138
Merged
auvipy merged 1 commit intoSep 5, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, correct guard for an empty-list edge case and includes a focused regression test covering the reported failure mode.
Pull request overview
This PR fixes an edge-case bug in ClickCompleter when shortest_only=True and completion is requested at the empty root prompt, preventing an args[-1] access on an empty args list and adding a regression test to lock in the behavior.
Changes:
- Guard shortest-only option selection against an empty
argslist in_get_completion_for_cmd_args. - Add a regression test ensuring shortest-only completion works at an empty root prompt and produces no stdout output.
File summaries
| File | Description |
|---|---|
click_repl/_completer.py |
Prevents indexing into an empty args list when applying shortest_only option filtering. |
tests/test_completion/test_common_tests/test_option_completion.py |
Adds regression coverage for completing at an empty root prompt with shortest_only=True. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
auvipy
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pytest