perf: replace the octokit meta-package with @octokit/core - #105
Merged
Merged
Conversation
Only @octokit/core (for .request) and @octokit/plugin-rest-endpoint-methods (for .rest.repos / .rest.users) are used. Dropping the umbrella `octokit` package removes @octokit/app, oauth-app, webhooks, plugin-retry, plugin-throttling, plugin-paginate-* and their deps. Worker bundle 558 kB -> 484 kB (gzip 138 -> 118), 202 -> 183 packages.
Deploying petithub with
|
| Latest commit: |
de98078
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d3737b28.petithub.pages.dev |
| Branch Preview URL: | https://petithub-slim-octokit.petithub.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up B from the review. The app only uses
octokit.request()(core) andoctokit.rest.repos.*/octokit.rest.users.getAuthenticated(rest-endpoint-methods plugin). Swapping the umbrellaoctokitpackage for@octokit/core+@octokit/plugin-rest-endpoint-methodsdrops@octokit/app,oauth-app,webhooks,plugin-retry,plugin-throttling,plugin-paginate-*and their transitive deps.src/utils/octokit.tsxnow buildsOctokit = Core.plugin(restEndpointMethods)and exports it (value + type); other files import the type from there.@octokit/request@10types some ids asnumber | bigint—getMaxIdnow coerces withNumber().Verified:
bun run typecheckclean,bun run buildOK,wrangler pages dev distboots and/,/api(401),/api/swagger(200),/github/login(302) all respond. Live GitHub calls couldn't be exercised offline — worth a glance at the first deploy that repos still load and login works.Further cut possible later: drop
plugin-rest-endpoint-methodstoo and use rawoctokit.request("GET /repositories")strings (~200 kB of endpoint metadata), at the cost of the typed helpers.