Skip to content

ci(e2e): point mobile-e2e to clerkstage-with-native-components instance#8495

Merged
wobsoriano merged 1 commit intomainfrom
chris/mobile-e2e-instance-name
May 6, 2026
Merged

ci(e2e): point mobile-e2e to clerkstage-with-native-components instance#8495
wobsoriano merged 1 commit intomainfrom
chris/mobile-e2e-instance-name

Conversation

@chriscanin
Copy link
Copy Markdown
Member

@chriscanin chriscanin commented May 6, 2026

Summary

  • Replaces the EXPO_INSTANCE_NAME: expo-native placeholder added in ci(expo): add manual mobile e2e workflow_dispatch #8489 with the real instance name clerkstage-with-native-components, which now exists in the INTEGRATION_INSTANCE_KEYS GitHub Actions secret.
  • Drops the two TODOs in the header/env comment

Without this, the manual Mobile e2e (@clerk/expo) workflow would fail at the "Resolve Clerk instance keys" step with No entry 'expo-native' found in INTEGRATION_INSTANCE_KEYS.

Test plan

  • Trigger the Mobile e2e (@clerk/expo) workflow from the Actions tab on main after this lands and confirm the "Resolve Clerk instance keys" step passes.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2026

⚠️ No Changeset found

Latest commit: 2389181

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 6, 2026 10:49pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

📝 Walkthrough

Walkthrough

The GitHub Actions mobile e2e workflow configuration was updated to change the EXPO_INSTANCE_NAME environment variable from expo-native to clerkstage-with-native-components. This change affects which integration instance key is resolved from secrets during workflow execution. The remainder of the workflow logic—including Android and iOS job structures, monorepo builds, Maestro flow execution, and test user provisioning/teardown—remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly explains the changes: replacing a placeholder EXPO_INSTANCE_NAME with a real instance name and removing TODOs, with valid reasoning about the workflow failure it addresses.
Title check ✅ Passed The title accurately summarizes the main change: updating the mobile-e2e workflow to use 'clerkstage-with-native-components' instead of 'expo-native' as the EXPO_INSTANCE_NAME.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscanin chriscanin requested a review from wobsoriano May 6, 2026 22:50
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8495

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8495

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8495

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8495

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8495

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8495

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8495

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8495

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8495

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8495

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8495

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8495

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8495

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8495

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8495

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8495

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8495

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8495

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8495

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8495

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8495

commit: 2389181

@chriscanin chriscanin changed the title ci(mobile-e2e): point to clerkstage-with-native-components instance ci(e2e): point mobile-e2e to clerkstage-with-native-components instance May 6, 2026
@wobsoriano wobsoriano merged commit 9ccec6d into main May 6, 2026
45 of 47 checks passed
@wobsoriano wobsoriano deleted the chris/mobile-e2e-instance-name branch May 6, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants